Skip to content

Make batch skipping of hempc3 files more efficient - #100

Merged
simonge merged 2 commits into
mainfrom
more-efficient-hepmc3-batch-skipping
Sep 29, 2026
Merged

simonge merged 2 commits into
mainfrom
more-efficient-hepmc3-batch-skipping

Conversation

@simonge

@simonge simonge commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

Another issue highlighted in a claude code review by @wenaus. Skipping of very large numbers of events required opening and checking the size of all files multiple times until the skip value was reached. This implements logic which keeps track of the number of events in each file and the total number of events so that once a first pass has been made, the correct file and event can be jumped to efficiently.

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Efficiency improvement in finding events after very large skip values

@simonge
simonge force-pushed the more-efficient-hepmc3-batch-skipping branch from 86ea30c to 76dcd5d Compare September 29, 2026 15:06
@github-actions

Copy link
Copy Markdown

TimeframeBuilder reports for PR #100

Last updated 2026-09-29T12:23-04:00 b4b9f2d

@simonge
simonge requested a review from a team September 29, 2026 16:32
@simonge
simonge merged commit 257e714 into main Sep 29, 2026
12 checks passed
@simonge
simonge deleted the more-efficient-hepmc3-batch-skipping branch September 29, 2026 20:39

This branch was previously deployed

1 inactive deployment
github-pages — 76dcd5d7 Deployed Sep 29, 2026 by simonge via deploy-docs #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant